ci: Fix integration tests failing on fork PRs#655
Merged
Conversation
vdusek
added
adhoc
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 96.45% 94.41% -2.04%
==========================================
Files 45 45
Lines 4318 4318
==========================================
- Hits 4165 4077 -88
- Misses 153 241 +88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The integration tests were failing on fork PRs with "Secret APIFY_TEST_USER_PYTHON_SDK_API_TOKEN is required, but not provided" because GitHub validates required secrets of nested reusable workflows at compile time, before evaluating job-level `if` conditions. Inline the integration test steps directly in _tests.yaml instead of calling the external reusable workflow. Regular job steps that reference secrets just get empty strings for fork PRs (no compile-time validation), and the `if` condition properly skips the job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
force-pushed
the
ci/fix-integration-tests-fork-prs
branch
from
957ac11 to
cec0cc5
Compare
Pijukatel
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchto the integration tests conditionsecrets: inheritfrom unit testsThis follows the same pattern as in the Python SDK: https://github.com/apify/apify-sdk-python/blob/master/.github/workflows/_tests.yaml
Test plan
apifyorg, pushes tomaster, and manual triggers🤖 Generated with Claude Code